Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docker and kubernetes tests and metadata for AIX #16369

Merged
merged 3 commits into from
Apr 6, 2022

Conversation

Helflym
Copy link
Contributor

@Helflym Helflym commented Feb 17, 2020

What does this PR do?

This PR disables tests based on docker or kubernetes features for AIX.
It also forces docker and kubernetes to be disable by mage configuration files.

Why is it important?

Docker doesn't work on AIX thus tests or anything else linked to it shouldn't be made on AIX.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

This is only aimed to be tested on AIX, but the part disabling the tests can be tried on any OS by changing the uname condition.

Related issues

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@andresrc andresrc added [zube]: Inbox Team:Services (Deprecated) Label for the former Integrations-Services team labels Mar 10, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@urso
Copy link

urso commented Mar 10, 2020

LGTM. Unfortunately you have a merge conflicts. Can you rebase please? Will start an internal CI process once the merge conflict is resolved.

@kvch
Copy link
Contributor

kvch commented Mar 13, 2020

jenkins test this

@kvch kvch self-assigned this Mar 13, 2020
@mergify
Copy link
Contributor

mergify bot commented Apr 7, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b remove-docker upstream/remove-docker
git merge upstream/master
git push upstream remove-docker

@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2021

This pull request does not have a backport label. Could you fix it @Helflym? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Sep 22, 2021
Clément Chigot added 2 commits January 21, 2022 10:24
By default, all go packages in the subdirectories are tested and thus
packages depending on Docker or Kubernetes. Skip them on AIX.
Docker or Kubernetes metadata are sometimes added by configuration.
As it will always be disabled on AIX, forces the params to be false
instead of changing every configurations.
@Helflym Helflym requested a review from a team as a code owner January 21, 2022 09:29
@rdner rdner self-assigned this Apr 6, 2022
@kvch kvch removed their assignment Apr 6, 2022
@rdner
Copy link
Member

rdner commented Apr 6, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Apr 6, 2022

update

✅ Branch has been successfully updated

@mergify mergify bot requested a review from a team as a code owner April 6, 2022 09:34
@rdner
Copy link
Member

rdner commented Apr 6, 2022

/test

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 6, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-06T09:45:03.352+0000

  • Duration: 82 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 22295
Skipped 1934
Total 24229

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@rdner
Copy link
Member

rdner commented Apr 6, 2022

I'll merge this PR without addressing linter issues, since it's a long pending PR.

@rdner rdner merged commit 2586519 into elastic:main Apr 6, 2022
@Helflym
Copy link
Contributor Author

Helflym commented Apr 6, 2022

Thanks for merging it. However, I'm no longer working on AIX thus I cannot test it. But as Docker is still not available on AIX it should be useful anyway.

kush-elastic pushed a commit to kush-elastic/beats that referenced this pull request May 2, 2022
By default, all go packages in the subdirectories are tested and thus
packages depending on Docker or Kubernetes. Skip them on AIX.

Docker or Kubernetes metadata are sometimes added by configuration.
As it will always be disabled on AIX, forces the params to be false
instead of changing every configurations.
@zube zube bot removed the [zube]: Done label Jul 6, 2022
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
By default, all go packages in the subdirectories are tested and thus
packages depending on Docker or Kubernetes. Skip them on AIX.

Docker or Kubernetes metadata are sometimes added by configuration.
As it will always be disabled on AIX, forces the params to be false
instead of changing every configurations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants