-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove docker and kubernetes tests and metadata for AIX #16369
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Pinging @elastic/integrations-services (Team:Services) |
LGTM. Unfortunately you have a merge conflicts. Can you rebase please? Will start an internal CI process once the merge conflict is resolved. |
jenkins test this |
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request does not have a backport label. Could you fix it @Helflym? 🙏
NOTE: |
By default, all go packages in the subdirectories are tested and thus packages depending on Docker or Kubernetes. Skip them on AIX.
Docker or Kubernetes metadata are sometimes added by configuration. As it will always be disabled on AIX, forces the params to be false instead of changing every configurations.
c6d7966
to
13e2798
Compare
@Mergifyio update |
✅ Branch has been successfully updated |
/test |
I'll merge this PR without addressing linter issues, since it's a long pending PR. |
Thanks for merging it. However, I'm no longer working on AIX thus I cannot test it. But as Docker is still not available on AIX it should be useful anyway. |
By default, all go packages in the subdirectories are tested and thus packages depending on Docker or Kubernetes. Skip them on AIX. Docker or Kubernetes metadata are sometimes added by configuration. As it will always be disabled on AIX, forces the params to be false instead of changing every configurations.
By default, all go packages in the subdirectories are tested and thus packages depending on Docker or Kubernetes. Skip them on AIX. Docker or Kubernetes metadata are sometimes added by configuration. As it will always be disabled on AIX, forces the params to be false instead of changing every configurations.
What does this PR do?
This PR disables tests based on docker or kubernetes features for AIX.
It also forces docker and kubernetes to be disable by mage configuration files.
Why is it important?
Docker doesn't work on AIX thus tests or anything else linked to it shouldn't be made on AIX.
Checklist
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
How to test this PR locally
This is only aimed to be tested on AIX, but the part disabling the tests can be tried on any OS by changing the uname condition.
Related issues