Fix for #1466 #1489
Merged
Fix for #1466 #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cause was a nil value in the incoming JSON, which the generic filtering code didn't expect. I considered adding a `recover` to generic filtering so that things like this don't crash the whole process, but decided against. One reason is that it's better to discover these things while we're still in alpha/beta. Second is that if we recover here, there could still be a crash later in filtering our outputs. Also took the opportunity to add a couple of system tests that combine json and generic filtering.
|
LGTM |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cause was a nil value in the incoming JSON, which the generic
filtering code didn't expect.
I considered adding a
recoverto genericfiltering so that things like this don't crash the whole process, but decided
against. One reason is that it's better to discover these things while we're
still in alpha/beta. Second is that if we recover here, there could still be a
crash later in filtering our outputs.
Also took the opportunity to add a couple of system tests that combine json
and generic filtering.