[Filebeat] Update Logstash module to support pipeline ID from 7.4 logs #14743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with Logstash 7.4.0, logs include the pipeline ID. Currently this caused the module to fail parsing this kind of logs.
|
Doubts:
|
ph
approved these changes
Nov 25, 2019
adriansr
added
the
needs_backport
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Nov 25, 2019
elastic#14743) Starting with Logstash 7.4.0, logs include the pipeline ID: from v7.4.x Logstash's config/log4j2.properties: > appender.console.layout.pattern = [%d{ISO8601}][%-5p][%-25c]%notEmpty{[%X{pipeline.id}]} %m%n Earlier version: > appender.console.layout.pattern = [%d{ISO8601}][%-5p][%-25c] %m%n Currently this caused the module to fail parsing logs with a Grok error. (cherry picked from commit 3780428)
adriansr
added
v7.6.0
and removed
needs_backport
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Nov 25, 2019
elastic#14743) Starting with Logstash 7.4.0, logs include the pipeline ID: from v7.4.x Logstash's config/log4j2.properties: > appender.console.layout.pattern = [%d{ISO8601}][%-5p][%-25c]%notEmpty{[%X{pipeline.id}]} %m%n Earlier version: > appender.console.layout.pattern = [%d{ISO8601}][%-5p][%-25c] %m%n Currently this caused the module to fail parsing logs with a Grok error. (cherry picked from commit 3780428)
adriansr
added a commit
that referenced
this pull request
Nov 26, 2019
#14743) (#14757) Starting with Logstash 7.4.0, logs include the pipeline ID: from v7.4.x Logstash's config/log4j2.properties: > appender.console.layout.pattern = [%d{ISO8601}][%-5p][%-25c]%notEmpty{[%X{pipeline.id}]} %m%n Earlier version: > appender.console.layout.pattern = [%d{ISO8601}][%-5p][%-25c] %m%n Currently this caused the module to fail parsing logs with a Grok error. (cherry picked from commit 3780428)
adriansr
added a commit
that referenced
this pull request
Nov 26, 2019
#14743) (#14756) Starting with Logstash 7.4.0, logs include the pipeline ID: from v7.4.x Logstash's config/log4j2.properties: > appender.console.layout.pattern = [%d{ISO8601}][%-5p][%-25c]%notEmpty{[%X{pipeline.id}]} %m%n Earlier version: > appender.console.layout.pattern = [%d{ISO8601}][%-5p][%-25c] %m%n Currently this caused the module to fail parsing logs with a Grok error. (cherry picked from commit 3780428)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
elastic#14743) (elastic#14757) Starting with Logstash 7.4.0, logs include the pipeline ID: from v7.4.x Logstash's config/log4j2.properties: > appender.console.layout.pattern = [%d{ISO8601}][%-5p][%-25c]%notEmpty{[%X{pipeline.id}]} %m%n Earlier version: > appender.console.layout.pattern = [%d{ISO8601}][%-5p][%-25c] %m%n Currently this caused the module to fail parsing logs with a Grok error. (cherry picked from commit 9f69305)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Logstash 7.4.0, logs include the pipeline ID:
from v7.4.x Logstash's config/log4j2.properties:
Earlier version:
Currently this caused the module to fail parsing logs with a Grok error.