Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typeconv package #14144

Merged
merged 3 commits into from
Oct 25, 2019
Merged

Conversation

urso
Copy link

@urso urso commented Oct 18, 2019

Move type conversion support to parse arbitrary go types into common.MapStr (and other types) from the memlog registry to libbeat for reuse.

@urso urso mentioned this pull request Oct 18, 2019
@urso urso added the review label Oct 18, 2019
@urso urso requested a review from a team October 23, 2019 00:09
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm, there are a few hound comments to fix.

@urso urso merged commit ef8c2be into elastic:feature-new-registry-file Oct 25, 2019
urso pushed a commit that referenced this pull request Nov 21, 2019
Move type conversion support to parse arbitrary go types into common.MapStr (and other types) from the memlog registry to libbeat for reuse.
urso pushed a commit that referenced this pull request Jan 16, 2020
Move type conversion support to parse arbitrary go types into common.MapStr (and other types) from the memlog registry to libbeat for reuse.
@urso urso deleted the typeconv-package branch February 10, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants