-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIEM] PANW: Use geo.name instead of geo.country_iso_code #14082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PANW's PAN-OS logs contain source and destination location fields defined as "source country or internal region for private addresses". These were being copied into source.geo.country_iso_code which caused problems as they contain non-standard values. This patch updates the module to copy those fields into source.geo.name which is the right free-form field to use. Fixes elastic#13272
Pinging @elastic/siem (Team:SIEM) |
tsg
approved these changes
Oct 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Oct 16, 2019
PANW's PAN-OS logs contain source and destination location fields defined as "source country or internal region for private addresses". These were being copied into source.geo.country_iso_code which caused problems as they contain non-standard values. This patch updates the module to copy those fields into source.geo.name which is the right free-form field to use. Fixes elastic#13272 (cherry picked from commit 06edbde)
adriansr
added a commit
that referenced
this pull request
Oct 16, 2019
PANW's PAN-OS logs contain source and destination location fields defined as "source country or internal region for private addresses". These were being copied into source.geo.country_iso_code which caused problems as they contain non-standard values. This patch updates the module to copy those fields into source.geo.name which is the right free-form field to use. Fixes #13272 (cherry picked from commit 06edbde)
jorgemarey
pushed a commit
to jorgemarey/beats
that referenced
this pull request
Jun 8, 2020
PANW's PAN-OS logs contain source and destination location fields defined as "source country or internal region for private addresses". These were being copied into source.geo.country_iso_code which caused problems as they contain non-standard values. This patch updates the module to copy those fields into source.geo.name which is the right free-form field to use. Fixes elastic#13272
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…lastic#14084) PANW's PAN-OS logs contain source and destination location fields defined as "source country or internal region for private addresses". These were being copied into source.geo.country_iso_code which caused problems as they contain non-standard values. This patch updates the module to copy those fields into source.geo.name which is the right free-form field to use. Fixes elastic#13272 (cherry picked from commit 8a430b0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PANW's PAN-OS logs contain source and destination location fields defined as "source country or internal region for private addresses". These were being copied into source.geo.country_iso_code which caused problems as they contain non-standard values.
This patch updates the module to copy those fields into source.geo.name which is the right free-form field to use.
Fixes #13272