Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] PANW: Use geo.name instead of geo.country_iso_code #14082

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

adriansr
Copy link
Contributor

PANW's PAN-OS logs contain source and destination location fields defined as "source country or internal region for private addresses". These were being copied into source.geo.country_iso_code which caused problems as they contain non-standard values.

This patch updates the module to copy those fields into source.geo.name which is the right free-form field to use.

Fixes #13272

PANW's PAN-OS logs contain source and destination location fields
defined as "source country or internal region for private addresses".
These were being copied into source.geo.country_iso_code which caused
problems as they contain non-standard values.

This patch updates the module to copy those fields into source.geo.name
which is the right free-form field to use.

Fixes elastic#13272
@adriansr adriansr added bug review needs_backport PR is waiting to be backported to other branches. Team:SIEM labels Oct 16, 2019
@adriansr adriansr requested a review from a team as a code owner October 16, 2019 08:20
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

Copy link
Contributor

@tsg tsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adriansr adriansr merged commit 06edbde into elastic:master Oct 16, 2019
adriansr added a commit to adriansr/beats that referenced this pull request Oct 16, 2019
PANW's PAN-OS logs contain source and destination location fields
defined as "source country or internal region for private addresses".
These were being copied into source.geo.country_iso_code which caused
problems as they contain non-standard values.

This patch updates the module to copy those fields into source.geo.name
which is the right free-form field to use.

Fixes elastic#13272

(cherry picked from commit 06edbde)
@adriansr adriansr added v7.4.1 and removed needs_backport PR is waiting to be backported to other branches. labels Oct 16, 2019
@adriansr adriansr deleted the fix_panw_13272 branch October 16, 2019 11:14
adriansr added a commit that referenced this pull request Oct 16, 2019
PANW's PAN-OS logs contain source and destination location fields
defined as "source country or internal region for private addresses".
These were being copied into source.geo.country_iso_code which caused
problems as they contain non-standard values.

This patch updates the module to copy those fields into source.geo.name
which is the right free-form field to use.

Fixes #13272

(cherry picked from commit 06edbde)
jorgemarey pushed a commit to jorgemarey/beats that referenced this pull request Jun 8, 2020
PANW's PAN-OS logs contain source and destination location fields
defined as "source country or internal region for private addresses".
These were being copied into source.geo.country_iso_code which caused
problems as they contain non-standard values.

This patch updates the module to copy those fields into source.geo.name
which is the right free-form field to use.

Fixes elastic#13272
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…lastic#14084)

PANW's PAN-OS logs contain source and destination location fields
defined as "source country or internal region for private addresses".
These were being copied into source.geo.country_iso_code which caused
problems as they contain non-standard values.

This patch updates the module to copy those fields into source.geo.name
which is the right free-form field to use.

Fixes elastic#13272

(cherry picked from commit 8a430b0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Filebeat] Palo Alto Networks module schema issue
3 participants