Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Correctly initialize the Logger for the TCP input instance. #11605

Merged
merged 2 commits into from
Apr 12, 2019
Merged

Fix: Correctly initialize the Logger for the TCP input instance. #11605

merged 2 commits into from
Apr 12, 2019

Conversation

ph
Copy link
Contributor

@ph ph commented Apr 2, 2019

With() function was called without the key to identify the value
passed as parameter.

@ph ph added review Filebeat Filebeat labels Apr 2, 2019
@ph ph requested a review from a team as a code owner April 2, 2019 15:57
@kvch
Copy link
Contributor

kvch commented Apr 11, 2019

Needs a rebase.

@ph ph added the needs_backport PR is waiting to be backported to other branches. label Apr 12, 2019
@ph
Fix: Correctly initialize the Logger for the TCP input instance.
fd93684 
`With()` function was called without the key to identify the value
passed as parameter.
@ph ph force-pushed the fix/tcp-logger branch from 4f79607 to fd93684 Compare April 12, 2019 13:49
@ph ph merged commit c5d4832 into elastic:master Apr 12, 2019
@ph ph mentioned this pull request Apr 12, 2019
Closed
@ph ph added v7.2.0 and removed needs_backport PR is waiting to be backported to other branches. labels Apr 12, 2019
@ph ph mentioned this pull request Apr 12, 2019
Merged
@ph ph added the v7.0.1 label Apr 12, 2019
@ph ph mentioned this pull request Apr 12, 2019
Merged
@ph ph added the v6.7.2 label Apr 12, 2019
ph added a commit that referenced this pull request Apr 23, 2019
@ph
Cherry-pick #11605 to 6.7: Fix: Correctly initialize the Logger for t…
9c02a8d 
…he TCP input instance. (#11785)

* Fix: Correctly initialize the Logger for the TCP input instance. (#11605)

* Fix: Correctly initialize the Logger for the TCP input instance.

`With()` function was called without the key to identify the value
passed as parameter.


(cherry picked from commit c5d4832)
ph added a commit that referenced this pull request Apr 26, 2019
@ph
Cherry-pick #11605 to 7.0: Fix: Correctly initialize the Logger for t…
d6d4645 
…he TCP input instance. (#11784)

* Fix: Correctly initialize the Logger for the TCP input instance. (#11605)

* Fix: Correctly initialize the Logger for the TCP input instance.

`With()` function was called without the key to identify the value
passed as parameter.


(cherry picked from commit c5d4832)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvch kvch kvch approved these changes

Assignees
No one assigned
Labels
Filebeat Filebeat review v6.7.2 v7.0.1 v7.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ph @kvch