Cherry-pick #10945 to 7.0: [Filebeat] NetFlow input support for custom field definitions #11223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c#10945) This PR adds support for loading custom (enterprise-specific) fields to the Filebeat NetFlow input. These fields can extend and/or override fields in NetFlow V9 and IPFIX. For compatibility, the feature uses the same field definition YAML format as Logstash's netflow codec plugin. A new configuration option custom_definitions consists of a list of paths to definition files. (cherry picked from commit cd49078)
houndci-bot
reviewed
Mar 13, 2019
| @@ -92,7 +94,15 @@ func (d DecoderV9) ReadFieldDefinition(buf *bytes.Buffer) (field fields.Key, len | |||
| return field, length, nil | |||
| } | |||
|
|
|||
| func (d DecoderV9) GetFields() fields.FieldDict { | |||
There was a problem hiding this comment.
exported method DecoderV9.GetFields should have comment or be unexported
| @@ -20,12 +20,20 @@ type Field struct { | |||
|
|
|||
| type FieldDict map[Key]*Field | |||
|
|
|||
| func RegisterFields(dict FieldDict) error { | |||
| func RegisterGlobalFields(dict FieldDict) error { | |||
There was a problem hiding this comment.
exported function RegisterGlobalFields should have comment or be unexported
| @@ -6,7 +6,7 @@ package fields | |||
|
|
|||
| import "fmt" | |||
|
|
|||
| var Fields = FieldDict{} | |||
| var GlobalFields = FieldDict{} | |||
There was a problem hiding this comment.
exported var GlobalFields should have comment or be unexported
houndci-bot
reviewed
Mar 13, 2019
| @@ -92,7 +94,15 @@ func (d DecoderV9) ReadFieldDefinition(buf *bytes.Buffer) (field fields.Key, len | |||
| return field, length, nil | |||
| } | |||
|
|
|||
| func (d DecoderV9) GetFields() fields.FieldDict { | |||
There was a problem hiding this comment.
exported method DecoderV9.GetFields should have comment or be unexported
| @@ -20,12 +20,20 @@ type Field struct { | |||
|
|
|||
| type FieldDict map[Key]*Field | |||
|
|
|||
| func RegisterFields(dict FieldDict) error { | |||
| func RegisterGlobalFields(dict FieldDict) error { | |||
There was a problem hiding this comment.
exported function RegisterGlobalFields should have comment or be unexported
| @@ -6,7 +6,7 @@ package fields | |||
|
|
|||
| import "fmt" | |||
|
|
|||
| var Fields = FieldDict{} | |||
| var GlobalFields = FieldDict{} | |||
There was a problem hiding this comment.
exported var GlobalFields should have comment or be unexported
andrewkroh
reviewed
Mar 13, 2019
|
@andrewkroh I will add an entry |
adriansr
force-pushed
the
backport_10945_7.0
branch
from
4ce131a to
158bdec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #10945 to 7.0 branch. Original message:
This PR adds support for loading custom (enterprise-specific) fields to the Filebeat NetFlow input.
These fields can extend and/or override fields in NetFlow V9 and IPFIX.
For compatibility, the feature uses the same field definition YAML format as Logstash's netflow codec plugin.
A new configuration option
custom_definitionsconsists of a list of paths to definition files.