[Metricbeats] Migrate uwsgi/status to ReporterV2 #11153
Conversation
fearful-symmetry
added
Team:Integrations
fearful-symmetry
changed the title
|
@fearful-symmetry I definitively would recommend to update the |
| totals := findItems(events, "total") | ||
| assert.Equal(t, 1, len(totals)) | ||
| } | ||
|
|
||
| func TestData(t *testing.T) { | ||
| compose.EnsureUp(t, "uwsgi_http") |
There was a problem hiding this comment.
We started to skip the EnsureUp in the TestData runs as it would boot up the environment but then on CI it skips the generation anyway. And when generating it locally, I personally always boot up the env manually.
|
Updated to fix a test and the compose line that @ruflin mentioned |
|
new data.json at @ruflin 's request. |
| "read_errors": 0, | ||
| "pid": 1 | ||
| }, | ||
|
|
There was a problem hiding this comment.
Seeing that empty line in here it definitively indicates this was generated manually. I'm glad we have a new one.
There was a problem hiding this comment.
Nice catch!
|
jenkins failure seems unrelated. |
|
jenkins, test this |
See #10774
This one was a bit of a pain, as it has a lot more tests and varies from the normal module setup in a number of ways. I ended up having to change a bit (and was tempted to clean some things up, but that's probably a job for a separate PR) so if anything seems unnecessary or weird just tell me.
I also didn't commit the updated data.json, as this PR is large enough and @sayden advised me against it.