Correctly bubble up errors when an integration test fails in a docker container. #10380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 28, 2019
|
Note: need backport to 6.0 6.x |
ph
changed the title
test As a retrospect leaving the invocation of `docker-compose logs` was a bad idea, first it could hide some error in the integration suite and it could add unnecessary long logs line in the CI job making debugging even harder. So instead, I've remove it completely and leave up to the person debugging to enabled it back.
ph
force-pushed
the
fix/test-docker-compose
branch
from
39c2f7c to
68f2464
Compare
ph
added
review
libbeat
:Testing
and removed
in progress
|
need backport to 6.x and 6.6 |
ruflin
reviewed
Jan 29, 2019
|
@ruflin I have added a comment with the docker-compose logs. |
ph
changed the title
ph
added
v6.7.0
and removed
needs_backport
ph
added a commit
that referenced
this pull request
Jan 29, 2019
… container. (#10380) (#10410) As a retrospect leaving the invocation of `docker-compose logs` was a bad idea, first it could hide some error in the integration suite and it could add unnecessary long logs line in the CI job making debugging even harder. So instead, I've remove it completely and leave up to the person debugging to enabled it back. (cherry picked from commit fd149bb)
ph
added a commit
that referenced
this pull request
Jan 30, 2019
… container. (#10380) (#10409) As a retrospect leaving the invocation of `docker-compose logs` was a bad idea, first it could hide some error in the integration suite and it could add unnecessary long logs line in the CI job making debugging even harder. So instead, I've remove it completely and leave up to the person debugging to enabled it back. (cherry picked from commit fd149bb)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
… container. (elastic#10380) (elastic#10410) As a retrospect leaving the invocation of `docker-compose logs` was a bad idea, first it could hide some error in the integration suite and it could add unnecessary long logs line in the CI job making debugging even harder. So instead, I've remove it completely and leave up to the person debugging to enabled it back. (cherry picked from commit c9ce1fe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a retrospect leaving the invocation of
docker-compose logswas abad idea, first it could hide some error in the integration suite and it
could add unnecessary long logs line in the CI job making debugging even harder.
So instead, I've remove it completely and leave up to the person debugging to enabled it back.