This repository has been archived by the owner on Mar 30, 2023. It is now read-only.
Prefix loadbalancers, application gateway and ip addresses with vmHostNamePrefix #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tNamePrefix This commit updates the load balancer, application gateway and ip address resources to be prefixed with the vmHostNamePrefix value. This would allow a cluster to be deployed into an existing resource group where another cluster has been deployed with a different vmHostNamePrefix value. Fixes #278
Mpdreamz
approved these changes
Jun 10, 2019
russcam
added a commit
that referenced
this pull request
Jun 11, 2019
…tNamePrefix (#285) This commit updates the load balancer, application gateway and ip address resources to be prefixed with the vmHostNamePrefix value. This would allow a cluster to be deployed into an existing resource group where another cluster has been deployed with a different vmHostNamePrefix value. Fixes #278
russcam
added a commit
that referenced
this pull request
Jun 11, 2019
…tNamePrefix (#285) This commit updates the load balancer, application gateway and ip address resources to be prefixed with the vmHostNamePrefix value. This would allow a cluster to be deployed into an existing resource group where another cluster has been deployed with a different vmHostNamePrefix value. Fixes #278
russcam
added a commit
that referenced
this pull request
Jun 11, 2019
This commit updates the app-gateway resource name used to validate a deployment, to align with changes in #285
russcam
added a commit
that referenced
this pull request
Jun 14, 2019
This commit updates the app-gateway resource name used to validate a deployment, to align with changes in #285
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the load balancer, application gateway and ip address resources to be prefixed with
the
vmHostNamePrefixvalue. This would allow a cluster to be deployed into an existing resource group where another cluster has been deployed with a differentvmHostNamePrefixvalue.The vnet is not prefixed with
vmHostNamePrefixbecause its name is an input parameter, so can be passed prefixed.Fixes #278