Markdown syntax: avoid a table here because it cannot handle pipes in cells #495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Flavored Markdown tables cannot cope with literal
|
(vertical bars) in cells data. They get interpreted as cell delimiters. That is a problem for the regexes in https://github.com/elastic/apm/blob/master/specs/agents/configuration.md#configuration-value-typesThe regexes below are incomplete when rendered:
Option 1
Per https://stackoverflow.com/questions/49809122/vertical-bar-symbol-within-a-markdown-table one workaround is using
|
and<code>...</code>
like so:Rendered:
^(-)?(\d+)(ms|s|m)$
^(\d+)(b|kb|mb|gb)$
The downside is that this regex is obscure for those reading the raw .md file in their editor.
Option 2
Use a list instead of a table.
Rendered: https://github.com/trentm/apm/blob/no-table-no-cry/specs/agents/configuration.md#configuration-value-types