-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add long_field_max_length configuration option #493
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
Trends 🧪 |
felixbarny
reviewed
Aug 24, 2021
felixbarny
approved these changes
Aug 24, 2021
I'm skipping PM approval. |
SylvainJuge
approved these changes
Aug 25, 2021
beniwohli
approved these changes
Aug 25, 2021
…se not important or widely implemented enough, we can add it later if needed
astorm
approved these changes
Aug 25, 2021
basepi
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to the discussion issue for a common config var for some of the longer fields that (a) aren't limited in length by the APM server intake API schema and (b) have some current agent-specific issues open to be made configurable.
Rendered here: https://github.com/trentm/apm/blob/long_field_max_length/specs/agents/field-limits.md
Some reviewer notes:
{transaction,error}.context.request.body
andspan.context.db.statement
only. I added some other potential candidate fields for this config var{transaction,span,error}.context.message.body
,error.exception.message
,error.log.message
. I have no strong preference on whether to include those other fields now, later or never. There are here for discussion. Thoughts? (The Node.js APM agent already has theerrorMessageMaxLength
config var for the latter two.)