Move labels and timestamp to model.APMEvent #5840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errors
Expand to view the tests failures
|
Remove Transaction.Labels, Span.Labels, etc., and combine
global labels ("metadata labels") with event-specific labels
at decoding and model construction time.
Remove modeldecoder.Input.RequestTime. Instead, we will have processor/stream initialise the base event's timestamp to the request time and leave it unmodified in the event that no timestamp is specified for the event.
axw
force-pushed
the
model-apmevent-timestamp
branch
from
000fd4f to
d9b777e
Compare
stuartnelson3
approved these changes
Aug 2, 2021
mergify bot
pushed a commit
that referenced
this pull request
Aug 2, 2021
* Remove event-specific Labels fields
Remove Transaction.Labels, Span.Labels, etc., and combine
global labels ("metadata labels") with event-specific labels
at decoding and model construction time.
* model: move Timestamp to APMEvent
* model/modeldecoder: adapt to APMEvent.Timestamp
Remove modeldecoder.Input.RequestTime. Instead, we will
have processor/stream initialise the base event's timestamp
to the request time and leave it unmodified in the event
that no timestamp is specified for the event.
* processor/otel: adapt to APMEvent.Timestamp
* aggregation: adapt to APMEvent.Timestamp
(cherry picked from commit c041e85)
axw
added a commit
that referenced
this pull request
Aug 2, 2021
* Remove event-specific Labels fields
Remove Transaction.Labels, Span.Labels, etc., and combine
global labels ("metadata labels") with event-specific labels
at decoding and model construction time.
* model: move Timestamp to APMEvent
* model/modeldecoder: adapt to APMEvent.Timestamp
Remove modeldecoder.Input.RequestTime. Instead, we will
have processor/stream initialise the base event's timestamp
to the request time and leave it unmodified in the event
that no timestamp is specified for the event.
* processor/otel: adapt to APMEvent.Timestamp
* aggregation: adapt to APMEvent.Timestamp
(cherry picked from commit c041e85)
Co-authored-by: Andrew Wilkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Checklist
- [ ] Update CHANGELOG.asciidoc- [ ] Documentation has been updatedHow to test these changes
Non-functional change.
Related issues
#4120
#3565