Restructure model.Metricset #5739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errors
Expand to view the tests failures
|
A few smallish changes to the model.Metricset type, for future-proofing. The goal is to make the type suitable for generating transformation to beat.Events logic later, while making the type better suited to protobuf definition in the short term. model.Metricset.Samples is now a map, instead of a slice of named metrics, and the metrics fields are added as flat dotted field namess rather than hierarchical objects. In the future we will send the samples map as-is (with values, type, and unit) to Elasticsearch and perform transformation to top-level metrics fields and dynamic templates completely in the ingest pipeline. model.Sample is now called model.MetricsetSample. We no longer set "_doc_count" in transformation; this is now part of the type and is set in transaction metrics aggregation for "transaction.duration.histogram", the only metric where it is expected to be set.
simitt
approved these changes
Jul 16, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jul 16, 2021
A few smallish changes to the model.Metricset type, for future-proofing. The goal is to make the type suitable for generating transformation to beat.Events logic later, while making the type better suited to protobuf definition in the short term. model.Metricset.Samples is now a map, instead of a slice of named metrics, and the metrics fields are added as flat dotted field namess rather than hierarchical objects. In the future we will send the samples map as-is (with values, type, and unit) to Elasticsearch and perform transformation to top-level metrics fields and dynamic templates completely in the ingest pipeline. model.Sample is now called model.MetricsetSample. We no longer set "_doc_count" in transformation; this is now part of the type and is set in transaction metrics aggregation for "transaction.duration.histogram", the only metric where it is expected to be set. (cherry picked from commit 4ac8c60)
axw
added a commit
that referenced
this pull request
Jul 16, 2021
A few smallish changes to the model.Metricset type, for future-proofing. The goal is to make the type suitable for generating transformation to beat.Events logic later, while making the type better suited to protobuf definition in the short term. model.Metricset.Samples is now a map, instead of a slice of named metrics, and the metrics fields are added as flat dotted field namess rather than hierarchical objects. In the future we will send the samples map as-is (with values, type, and unit) to Elasticsearch and perform transformation to top-level metrics fields and dynamic templates completely in the ingest pipeline. model.Sample is now called model.MetricsetSample. We no longer set "_doc_count" in transformation; this is now part of the type and is set in transaction metrics aggregation for "transaction.duration.histogram", the only metric where it is expected to be set. (cherry picked from commit 4ac8c60) Co-authored-by: Andrew Wilkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
A few smallish changes to the
model.Metricsettype, for future-proofing. The goal is to make the type suitable for generating transformation tobeat.Eventslogic later, while making the type better suited to protobuf definition in the short term.model.Metricset.Samplesis now a map, instead of a slice of named metrics, and the metrics fields are added as flat dotted field namess rather than hierarchical objects.In the future we will send the samples map as-is (with values, type, and unit) to Elasticsearch and perform transformation to top-level metrics fields and dynamic templates completely in the ingest pipeline.
model.Sampleis now calledmodel.MetricsetSample, to clarify its relationship withmodel.Metricset.We no longer set "_doc_count" in transformation; this is now part of the type and is set in transaction metrics aggregation
for "transaction.duration.histogram", the only metric where it is expected to be set.
Checklist
- [ ] Update CHANGELOG.asciidoc- [ ] Documentation has been updatedHow to test these changes
Non-functional change.
Related issues
#4120
#3565