Move more code from model to model processors #5687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
force-pushed
the
modelprocessor-frames
branch
from
a6e0b19 to
62a6504
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
axw
force-pushed
the
modelprocessor-frames
branch
2 times, most recently
from
a5d9bb9 to
292f301
Compare
Move more logic out of model transformation, into dedicated model processors: - modelprocessor.SetExcludeFromGrouping matches stack frames against a regular expression, setting the "exclude_from_grouping" field - modelprocessor.SetLibraryFrame matches stack frames against a regular expression, setting the "library_frame" field - modelprocessor.SetCulprit identifies the first source mapped, non-library, stack frame and uses it to set or update the error culprit The "library_frame" field is now only set if it is true. The UI uses this field but takes omission to mean the same thing as false (i.e. "falsy") The new model processors are only installed for the RUM intake APIs. With these changes, we no longer need to identify events as originating from the RUM endpoint, so we remove the model.Span.RUM and model.Error.RUM fields.
axw
force-pushed
the
modelprocessor-frames
branch
from
292f301 to
5afe6fb
Compare
|
/test |
1 similar comment
|
/test |
|
This pull request is now in conflicts. Could you fix it @axw? 🙏 |
simitt
approved these changes
Jul 15, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jul 15, 2021
Move more logic out of model transformation, into dedicated model processors: - modelprocessor.SetExcludeFromGrouping matches stack frames against a regular expression, setting the "exclude_from_grouping" field - modelprocessor.SetLibraryFrame matches stack frames against a regular expression, setting the "library_frame" field - modelprocessor.SetCulprit identifies the first source mapped, non-library, stack frame and uses it to set or update the error culprit The "library_frame" field is now only set if it is true. The UI uses this field but takes omission to mean the same thing as false (i.e. "falsy") The new model processors are only installed for the RUM intake APIs. With these changes, we no longer need to identify events as originating from the RUM endpoint, so we remove the model.Span.RUM and model.Error.RUM fields. (cherry picked from commit ce483db)
axw
added a commit
that referenced
this pull request
Jul 15, 2021
Move more logic out of model transformation, into dedicated model processors: - modelprocessor.SetExcludeFromGrouping matches stack frames against a regular expression, setting the "exclude_from_grouping" field - modelprocessor.SetLibraryFrame matches stack frames against a regular expression, setting the "library_frame" field - modelprocessor.SetCulprit identifies the first source mapped, non-library, stack frame and uses it to set or update the error culprit The "library_frame" field is now only set if it is true. The UI uses this field but takes omission to mean the same thing as false (i.e. "falsy") The new model processors are only installed for the RUM intake APIs. With these changes, we no longer need to identify events as originating from the RUM endpoint, so we remove the model.Span.RUM and model.Error.RUM fields. (cherry picked from commit ce483db) Co-authored-by: Andrew Wilkins <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
|
Confirmed with BC2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Move more logic out of model transformation, into dedicated model processors:
modelprocessor.SetExcludeFromGroupingmatches stack frames against a regular expression, setting the "exclude_from_grouping" fieldmodelprocessor.SetLibraryFramematches stack frames against a regular expression, setting the "library_frame" fieldmodelprocessor.SetCulpritidentifies the first source mapped, non-library, stack frame and uses it to set or update the error culpritThe "library_frame" field is now only set if it is true, to simplify code and keep documents minimal. The UI collapses stack frames identified as library frames, but takes omission to mean the same thing as false, i.e. "falsy", so this change has no other practical effects.
The new model processors are only installed for the RUM intake APIs. With these changes, we no longer need to identify events as originating from the RUM endpoint, so we remove the
model.Span.RUMandmodel.Error.RUMfields.How to test these changes
Send an exception event to APM Server, check that (non-)library frames are still differentiated.
Related issues
Pulling logic out of model transformation for