Format code, change tests/system to avoid breakage #4459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autopep8 will move imports to the top of the file if they come after statements. Move the sys.path magic to another file so we can preserve import ordering.
Codecov Report
@@ Coverage Diff @@
## master #4459 +/- ##
==========================================
+ Coverage 76.11% 76.13% +0.02%
==========================================
Files 158 158
Lines 9782 9782
==========================================
+ Hits 7446 7448 +2
+ Misses 2336 2334 -2
|
10 tasks
mdelapenya
approved these changes
Nov 25, 2020
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
simitt
pushed a commit
to simitt/apm-server
that referenced
this pull request
Dec 10, 2020
autopep8 will move imports to the top of the file if they come after statements. Move the sys.path magic to another file so we can preserve import ordering.
axw
added a commit
that referenced
this pull request
Dec 14, 2020
autopep8 will move imports to the top of the file if they come after statements. Move the sys.path magic to another file so we can preserve import ordering. Co-authored-by: Andrew Wilkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
autopep8 will move imports to the top of the file
if they come after statements. Move the sys.path
magic to another file so we can preserve import
ordering.
Checklist
- [ ] I have updated CHANGELOG.asciidocI have considered changes for:
- [ ] documentation- [ ] logging (add log lines, choose appropriate log selector, etc.)- [ ] metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)- [ ] telemetry- [ ] Elasticsearch Service (https://cloud.elastic.co)- [ ] Elastic Cloud Enterprise (https://www.elastic.co/products/ece)- [ ] Elastic Cloud on Kubernetes (https://www.elastic.co/elastic-cloud-kubernetes)How to test these changes
make fmt, should result in no changes.make system-tests, should run successfullyRelated issues
Closes #4454