Add metadata modeldecoder and generator logic #4154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduce modeldecoder models for metadata with nullable values * Generate model decoding and validation functions * Run generator logic on `make update`
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
axw
reviewed
Sep 7, 2020
* switch from pkg name `type` to `nullable` * rename Decoder methods * simplify v2 validation test logic * minor refactorings
axw
reviewed
Sep 8, 2020
1 task
axw
pushed a commit
to axw/apm-server
that referenced
this pull request
Sep 23, 2020
* Add metadata modeldecoder and generator logic * Introduce modeldecoder models for metadata with nullable values * Generate model decoding and validation functions * Run generator logic on `make update`
axw
added a commit
that referenced
this pull request
Sep 23, 2020
* Add metadata modeldecoder and generator logic * Introduce modeldecoder models for metadata with nullable values * Generate model decoding and validation functions * Run generator logic on `make update` Co-authored-by: Silvia Mitter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
This is the first PR introducing some ground work for the new json decoding + validation handling.
The changes are implemented for the
metadataand not yet used. We should integrate with the new logic, once we also have the code generation logic ready for creating json schema for testing purposes of the agents. To keep PRs relatively short and reviewable I suggest to put up isolated PRs for yet unused logic that are tested in themselves and the put everything together when it's ready.If interested there is a draft PR up showing the whole integration.
This PR introduces:
metadatawith nullable values forv2andrumv3make updateChecklist
- [ ] I have signed the Contributor License Agreement.- [ ] I have updated CHANGELOG.asciidocI have considered changes for:
- [ ] documentation- [ ] logging (add log lines, choose appropriate log selector, etc.)- [ ] metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)- [ ] telemetry- [ ] Elasticsearch Service (https://cloud.elastic.co)- [ ] Elastic Cloud Enterprise (https://www.elastic.co/products/ece)- [ ] Elastic Cloud on Kubernetes (https://www.elastic.co/elastic-cloud-kubernetes)How to test these changes
run
make update && make testRelated issues
#3551