-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change sourcemap logging #4132
Change sourcemap logging #4132
Conversation
Remove unnecessary log line and change other from warning to debug level. fixes elastic#4119
💚 Build SucceededExpand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
Remove unnecessary log line and change other from warning to debug level. fixes elastic#4119
@simitt Im confused by the test instructions, service.name is required in the payload, isnt it? |
There was a bug in the intake validation, so that |
fixes #4119
Motivation/summary
Remove unnecessary log line for source mapping and change potentially interesting log line from warning to debug level.
Checklist
- [ ] I have signed the Contributor License Agreement.- [ ] I have updated CHANGELOG.asciidocI have considered changes for:
- [ ] documentation- [ ] metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)- [ ] telemetry- [ ] Elasticsearch Service (https://cloud.elastic.co)- [ ] Elastic Cloud Enterprise (https://www.elastic.co/products/ece)- [ ] Elastic Cloud on Kubernetes (https://www.elastic.co/elastic-cloud-kubernetes)How to test these changes
Start APM Server with source mapping enabled
service.name
, check that nothing is logged.Change log level to debug and repeat sending a request for which no sourcemap can be retrieved - a message should be logged
Related issues
#4119