Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] ILM documentation #2231

Merged
merged 5 commits into from
Jun 12, 2019
Merged

[docs] ILM documentation #2231

merged 5 commits into from
Jun 12, 2019

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented May 29, 2019 •
edited
Loading

Closes #2136
Needs #2228 (xpack security improvements from Beats)

Rough draft up for @simitt and I to discuss on Monday. Lot's of work to do here still, don't get too excited 😄

Conversation with Silvia on Jun 4:

  • Do not document ability to change ILM policy. This is because it can take up to seven days for the changes to take effect.
  • Keep the manual ILM instructions around for now. For users that want to customize ILM, point them at this solution.
  • Encourage the user to use the setup command
  • Privileges required for APM Server:
    • cluster: manage_ilm
    • indices: manage, manage_ilm

@bmorelli25 bmorelli25 self-assigned this May 29, 2019
simitt
simitt reviewed Jun 3, 2019
View reviewed changes
docs/ilm.asciidoc Outdated Show resolved Hide resolved
docs/ilm.asciidoc Outdated Show resolved Hide resolved
docs/ilm.asciidoc Outdated Show resolved Hide resolved
docs/ilm.asciidoc Outdated Show resolved Hide resolved
docs/ilm.asciidoc Outdated Show resolved Hide resolved
docs/ilm.asciidoc Outdated Show resolved Hide resolved
docs/ilm.asciidoc Outdated Show resolved Hide resolved
docs/ilm.asciidoc Outdated Show resolved Hide resolved
docs/ilm.asciidoc Outdated Show resolved Hide resolved
docs/ilm.asciidoc Outdated Show resolved Hide resolved
@bmorelli25 bmorelli25 marked this pull request as ready for review June 5, 2019 04:44
@bmorelli25
Copy link
Member Author

bmorelli25 commented Jun 5, 2019 •
edited
Loading

@simitt, I'm ready for another look at this. One comment/question above ^

The docs ci failure is unrelated to this PR.

simitt
simitt approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple to digest, great explanations!

docs/ilm.asciidoc Outdated Show resolved Hide resolved
docs/ilm.asciidoc Show resolved Hide resolved
@bmorelli25
Copy link
Member Author

Rebased, which should fix the failing docs build.

Thank you so much @simitt for all of your help!

This was referenced Jun 5, 2019
Closed
Closed
@bmorelli25 bmorelli25 changed the title [WIP][docs] ILM documentation [docs] ILM documentation Jun 12, 2019
@bmorelli25
Copy link
Member Author

Had to rebase the branch. Everything looks good on this PR! Will merge once tests go green.

@bmorelli25 bmorelli25 merged commit 51942e8 into elastic:master Jun 12, 2019
@bmorelli25 bmorelli25 deleted the docs-ILM branch June 12, 2019 18:10
bmorelli25 added a commit to bmorelli25/apm-server that referenced this pull request Jun 17, 2019
@bmorelli25
[docs] ILM documentation (elastic#2231)
ea39406
@bmorelli25 bmorelli25 mentioned this pull request Jun 17, 2019
Merged
bmorelli25 added a commit to bmorelli25/apm-server that referenced this pull request Jun 17, 2019
@bmorelli25
[docs] ILM documentation (elastic#2231)
3825fb7
@bmorelli25 bmorelli25 mentioned this pull request Jun 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simitt simitt simitt approved these changes

Assignees

@bmorelli25 bmorelli25

Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document ILM support in APM Server
2 participants
@bmorelli25 @simitt