Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add geoip + default pipeline definitions #2177

Merged
merged 5 commits into from
May 20, 2019
Merged

add geoip + default pipeline definitions #2177

merged 5 commits into from
May 20, 2019

Conversation

graphaelli
Copy link
Member

Adds two new pipeline definitions without changing the existing apm_user_agent:

  • apm_user_geo - only GeoIP resolution of client.ip to client.geo
  • apm - both apm_user_agent and apm_user_geo

updates the default pipeline suggested in apm-server.yml

closes #1283

updates the default pipeline suggested in apm-server.yml
Copy link
Contributor

@jalvz jalvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could do with some integration test if not too complicated

@simitt
Copy link
Contributor

simitt commented May 10, 2019

I agree, fwiw there are already some pipeline registration and pipeline setup system tests that you could extend.

@graphaelli graphaelli merged commit f15d820 into master May 20, 2019
@graphaelli graphaelli deleted the geoip-pipeline branch May 20, 2019 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add geo ip pipeline to default pipeline definitions in APM Server
3 participants