[tests] check all keys in events. #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simitt
force-pushed
the
ecs-adapt-system-tests
branch
from
53d983b to
5c9a614
Compare
graphaelli
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The system approval tests did not actually check the whole document, but only everything under the event key,
@timestampandcontext. Since we are moving out everything fromcontextall the other top level keys have not been tested.There are some exceptions:
observer: The information in observer is related to where the apm-server is running, so most of the values cannot be checked. The test only looks at the keys being present.host: libbeat does automatically sethost.namewhich is considered a bug right now and needs to be removed, see Ensure libbeat does not sethost.name#1846