Kafka: Support specifying client certificates #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for Kafka to use client certificates based on two new env variables `KAFKA_TLS_CERT_PATH` and `KAFKA_TLS_KEY_PATH`. The current implementation supports hot reloading by checking if the file write time is greater than the last time it was read. Most of the changes are in the form of unit tests. Signed-off-by: Marc Lopez Rubio <[email protected]>
Signed-off-by: Marc Lopez Rubio <[email protected]>
inge4pres
reviewed
Feb 25, 2025
Signed-off-by: Marc Lopez Rubio <[email protected]>
inge4pres
reviewed
Feb 25, 2025
| dialFn, err := newCertReloadingDialer(caCertPath, cfg.TLS) | ||
| // Set a dialer that reloads the CA cert when the file changes. | ||
| dialFn, err := newCertReloadingDialer( | ||
| caCertPath, certPath, keyPath, 30*time.Second, cfg.TLS, |
There was a problem hiding this comment.
Question: what happens in between the time that the certificate changed and it is reloaded?
Do we risk to lose data because the connection is rejected?
There was a problem hiding this comment.
The old certificate should still be valid and loaded in memory, so no risk of data loss as far as I understand.
inge4pres
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Kafka to use client certificates based on two new env variables
KAFKA_TLS_CERT_PATHandKAFKA_TLS_KEY_PATH. The current implementation supports hot reloading by checking if the file write time is greater than the last time it was read.Most of the changes are in the form of unit tests.