producer.messages.count: Use kgo.Err as reason
#593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the `error_reason` dimension to use the value from the returned error (`kgo.Err.Message`). This allows us to classify the errors with the reason more granularly. Previously, all the produce failures that aren't due to `context.Done()` would be classified as `unknown`. Signed-off-by: Marc Lopez Rubio <[email protected]>
carsonip
previously approved these changes
Nov 6, 2024
|
Can you also update the docs on metrics of various services that depend on apm-queue? |
Signed-off-by: Marc Lopez Rubio <[email protected]>
This reverts commit d78b865.
Signed-off-by: Marc Lopez Rubio <[email protected]>
carsonip
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
error_reasondimension to use the value from the returned error (kgo.Err.Message). This allows us to classify the errors with the reason more granularly.Previously, all the produce failures that aren't due to
context.Done()would be classified asunknown.