address review comments

Signed-off-by: Marc Lopez Rubio <[email protected]>
elastic · Feb 25, 2025 · 527ed11 · 527ed11
1 parent 0789c25
commit 527ed11
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/kafka/common.go b/kafka/common.go
@@ -220,7 +220,7 @@ func (cfg *CommonConfig) finalize() error {
 		caCertPath := os.Getenv("KAFKA_TLS_CA_CERT_PATH")
 		if tlsInsecure && (caCertPath != "" || certPath != "" || keyPath != "") {
 			errs = append(errs, errors.New(
-				"kafka: cannot set both KAFKA_TLS_INSECURE and KAFKA_TLS_CA_CERT_PATH, KAFKA_TLS_CERT_PATH, or KAFKA_TLS_KEY_PATH",
+				"kafka: cannot set KAFKA_TLS_INSECURE when either of KAFKA_TLS_CA_CERT_PATH, KAFKA_TLS_CERT_PATH, or KAFKA_TLS_KEY_PATH are set",
 			))
 			break
 		}

diff --git a/kafka/common_test.go b/kafka/common_test.go
@@ -84,7 +84,7 @@ func TestCommonConfig(t *testing.T) {
 			Brokers: []string{"broker"},
 			Logger:  zap.NewNop(),
 		},
-			"kafka: cannot set both KAFKA_TLS_INSECURE and KAFKA_TLS_CA_CERT_PATH, KAFKA_TLS_CERT_PATH, or KAFKA_TLS_KEY_PATH",
+			"kafka: cannot set KAFKA_TLS_INSECURE when either of KAFKA_TLS_CA_CERT_PATH, KAFKA_TLS_CERT_PATH, or KAFKA_TLS_KEY_PATH are set",
 		)
 	})