fix(rum-react): memoizing function component to avoid unmount #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigneshshanmugam
changed the title
|
jenkins run the tests please |
cauemarcondes
commented
Apr 8, 2020
| @@ -40,6 +41,45 @@ function isReactClassComponent(Component) { | |||
| return !!(prototype && prototype.isReactComponent) | |||
| } | |||
|
|
|||
| const getMemoizedApmComponent = memoize((Component, apm, name, type) => { | |||
There was a problem hiding this comment.
@dgieselaar WDYT about memoize a function that returns a Component? I'm not sure about it. I need to do it to avoid creating a new ApmComponent every time a change happens in the URL.
There was a problem hiding this comment.
Well, it's a memory leak I think. I would at least tie it to the lifecycle of a container (e.g. by using getDerivedStateFromProps). I think you also might be able to rewrite this to a component that takes apm, name and type as props, and then you don't need memoization at all.
cauemarcondes
commented
Apr 8, 2020
| } | ||
|
|
||
| componentDidMount() { | ||
| ApmComponent = React.useCallback( |
There was a problem hiding this comment.
In case of hooks is available we can use useCallBack to memoize the component.
This was referenced Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.