-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more context to MongoDB Span #1604
Conversation
❕ Build Aborted
Expand to view the summary
Build stats
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this - I added 1 thing regarding Service.Resource
which should be removed.
Additionally, we'd also need to adapt tests to cover this.
The rest looks good - nice catch! 👍
DnsEndPoint dnsEndPoint => new Destination { Address = dnsEndPoint.Host, Port = dnsEndPoint.Port }, | ||
DnsEndPoint dnsEndPoint => new Destination | ||
{ | ||
Service = new Destination.DestinationService |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -55,7 +55,7 @@ private void HandleCommandStartEvent(CommandStartedEvent @event) | |||
var span = currentExecutionSegment.StartSpan( | |||
@event.CommandName, | |||
ApiConstants.TypeDb, | |||
"mongo", isExitSpan: true); | |||
"mongodb", isExitSpan: true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice - indeed, this should be mongodb
.
This is done in #1677. |
Before

After
