-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Performance counter handling #1536
Conversation
This commit improves the handling of performance counters used to get the total CPU % time on Windows. When the "Processor" performance counter category does not exist, try using the "Processor Information" category name. Include information in the log message about checking permissions only when a SecurityException is thrown. Closes elastic#1505
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Catch correct security exception
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me. I added 1 suggestion to the doc change.
/test |
This commit improves the handling of performance counters
used to get the total CPU % time on Windows. When
the "Processor" performance counter category does not exist,
try using the "Processor Information" category name.
Include information in the log message about checking permissions
only when a SecurityException is thrown.
Closes #1505