Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Performance counter handling #1536

Merged
merged 6 commits into from
Nov 3, 2021

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Oct 28, 2021

This commit improves the handling of performance counters
used to get the total CPU % time on Windows. When
the "Processor" performance counter category does not exist,
try using the "Processor Information" category name.

Include information in the log message about checking permissions
only when a SecurityException is thrown.

Closes #1505

This commit improves the handling of performance counters
used to get the total CPU % time on Windows. When
the "Processor" performance counter category does not exist,
try using the "Processor Information" category name.

Include information in the log message about checking permissions
only when a SecurityException is thrown.

Closes elastic#1505
@russcam russcam added bug Something isn't working v1.12.0 labels Oct 28, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Oct 28, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-02T22:55:53.057+0000

  • Duration: 51 min 45 sec

  • Commit: 7fc4085

Test stats 🧪

Test Results
Failed 0
Passed 19756
Skipped 127
Total 19883

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

@russcam
Copy link
Contributor Author

russcam commented Nov 1, 2021

/test

@gregkalapos gregkalapos self-requested a review November 2, 2021 18:47
Copy link
Contributor

@gregkalapos gregkalapos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. I added 1 suggestion to the doc change.

@russcam
Copy link
Contributor Author

russcam commented Nov 2, 2021

/test

@russcam russcam merged commit b33d209 into elastic:master Nov 3, 2021
@russcam russcam deleted the fix/perf-counter-handling branch November 3, 2021 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-dotnet bug Something isn't working v1.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Failed instantiating PerformanceCounter
3 participants