Make sure BreakdownMetricsProvider prints 1K warning only once per collection #1367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1361
Prior to this PR once
BreakdownMetricsProvider
reached the 1K metricset limit, it pinted a warning after each transaction. With a high number of transactions this can span logs.This PR changes this to print this log only once in every metics collection round. So in every MeticInterval (by default 30sec) we'll print the warning once if the 1K limit is reached. This also reflects reality better, since once the 1K limit is reached, we reset it after the current
List<MetricSet>
is sent to the server.