Get transaction name from Web API controller route template #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
This commit updates ElasticApmModule to get the transaction name for a Web API controller routed with attribute routing from the "MS_SubRoutes" route data value. A delegate to get the template from IHttpRouteData when System.Web.Http is referenced. Closes elastic#1176
russcam
force-pushed
the
feature/web-api-sub-route
branch
from
bcabfea to
b1fb135
Compare
Codecov Report
@@ Coverage Diff @@
## master #1189 +/- ##
==========================================
- Coverage 81.49% 81.35% -0.14%
==========================================
Files 163 164 +1
Lines 6836 6844 +8
==========================================
- Hits 5571 5568 -3
- Misses 1265 1276 +11
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates ElasticApmModule to get the transaction
name for a Web API controller routed with attribute routing
from the "MS_SubRoutes" route data value.
A delegate to get the template from IHttpRouteData when
System.Web.Http is referenced.
Closes #1176