-
Notifications
You must be signed in to change notification settings - Fork 858
Define a proxy for plugin installation #60
Define a proxy for plugin installation #60
Conversation
Address the issue [ansible-elasticsearch #4](#4) which add proxy for plugin installation and more generally es_proxy_host and es_proxy_port for global usage. Right now, it’s only used for plugins installation. In the futur, it can be used (or defined) in the java_opts within the default file for instance (elasticsearch.j2)
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
jenkins, test it |
Thank you so much for the contribution! I'll let jenkins do its magic. |
@electrical I signed the CLA, but I don't know if it applied on this PR |
Never mind. I was in the hurry :) |
jenkins, test it |
failed some runs so trying again. |
@electrical I think there are version incompatibility between net-ssh and ruby during tests. In all failed tests, I got this error: |
Yeah. will do some tests locally and fix the Gemfile. |
Hi @barryib picking this up as @electrical isn't focused on this anymore. Lets get it tested again and ill see if i can resolve. |
jenkins, test it |
1 similar comment
jenkins, test it |
@barryib If the tests pass ill merge |
jenkins, test it |
LGTM |
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
Define a proxy for plugin installation
Address the issue ansible-elasticsearch #4 which add proxy for plugin installation and more generally es_proxy_host and es_proxy_port for global usage.
Right now, it’s only used for plugins installation. In the futur, it can be used (or defined) in the java_opts within the default file for instance (elasticsearch.j2)