Make create faces optional #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elalish
commented
Sep 17, 2024
| if (meshGL.runOriginalID.empty()) { | ||
| // FIXME: This affects Impl::InitializeOriginal, and removing this | ||
| // apparently make things fail. Not sure if this is expected. | ||
| meshRelation_.originalID = Impl::ReserveIDs(1); |
There was a problem hiding this comment.
FYI @pca006132 I fixed this as part of the rest of this cleanup.
| for (int i = 0; i < numTri; ++i) { | ||
| for (const int j : {0, 1, 2}) { | ||
| triProperties[i][j] = idx++; | ||
| triProperties[i][j] = pImpl->halfedge_[3 * i + j].startVert; |
There was a problem hiding this comment.
This bug was causing duplicate propVerts to be created unnecessarily.
| CalculateNormals(); | ||
| InitializeOriginal(); | ||
| CreateFaces({}); | ||
| SimplifyTopology(); |
There was a problem hiding this comment.
FYI @Kushal-Shah-03 I simplified the hull setup - hopefully improves the speed a bit.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateFace()scales pretty poorly with model size and isn't always needed, so I'm removing it from a bunch of our functions and expecting users to callAsOriginal()instead when they want coplanar faces identified. I've also simplified some tests, which identified some existing bugs, particularly inSetProperties, so there are some fixes here as well.I'm still thinking through the API implications of all this and trying to make sure I have the right shape. I've also removed
propertyTolerancefrom our constructors - it is only needed forCreateFaces, so now it's just an input toAsOriginal.Next I'm going to work on a follow-on that splits the concepts of
faceIDand coplanarity. I believe this will allow me to remove the slow part ofCreateFacesentirely (connected components) and allowWarpandRefineto retain their mesh relations - currently those get destroyed since coplanarity gets broken.