Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BatchBoolean to Python API, both CS & M. #707

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Added BatchBoolean to Python API, both CS & M. #707

merged 1 commit into from
Jan 16, 2024

Conversation

briansturgill
Copy link
Contributor

Starting to find this easy. :-)
Simple add of functions, with tests.
Had to add a comment in manifold.cpp (used a similar one to that in cross_section.cpp).

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e27c9c1) 91.67% compared to head (d73b4f7) 91.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #707   +/-   ##
=======================================
  Coverage   91.67%   91.67%           
=======================================
  Files          37       37           
  Lines        4730     4730           
=======================================
  Hits         4336     4336           
  Misses        394      394           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pca006132 pca006132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pca006132 pca006132 merged commit f407e43 into elalish:master Jan 16, 2024
18 checks passed
cartesian-theatrics pushed a commit to SovereignShop/manifold that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants