Misc #640
Misc #640
Conversation
pca006132
commented
Dec 8, 2023
pca006132
commented
- Makes tracy support better.
- Remove some warnings from clang and clang-tidy.
| @@ -13,26 +13,17 @@ | |||
| // limitations under the License. | |||
|
|
|||
| #include "polygon.h" | |||
| #if MANIFOLD_PAR == 'T' | |||
| #include "tbb/tbb.h" | |||
|
|
||
| // Helper function used to swap X with Y and Y with X if c == true | ||
| void CondSwap(bool c, float& X, float& Y) { | ||
| inline void CondSwap(bool c, float& X, float& Y) { |
| @@ -289,7 +289,7 @@ struct SVDSet { | |||
| * | |||
| * @param A The matrix to decompose. | |||
| */ | |||
| SVDSet SVD(glm::mat3 A) { | |||
| inline SVDSet SVD(glm::mat3 A) { | |||
There was a problem hiding this comment.
Should we move this into a .cpp? I'm not completely clear on the tradeoffs.
There was a problem hiding this comment.
Probably not much pros and cons, more like ideological issue. If this is complicated and used in multiple places, putting it in a .cpp will reduce compilation time a bit, but it is not the case here.
| #define FrameMarkStart(x) | ||
| #define FrameMarkEnd(x) | ||
| #define ZoneScoped | ||
| #define ZoneScopedN(name) |
There was a problem hiding this comment.
Maybe a good place to document how we should use ZoneScoped? I have a vague idea from your usage, but I'm not entirely sure what it does.
There was a problem hiding this comment.
Sure, it is just something to mark the current zone (scope) for the profiler to see.
| @@ -144,6 +144,7 @@ Contributions are welcome! A lower barrier contribution is to simply make a PR t | |||
|
|
|||
| There is now basic support for the [Tracy profiler](https://github.com/wolfpld/tracy) for our tests. | |||
| To enable tracing, compile with `-DTRACY_ENABLE=on` cmake option, and run the test with Tracy server running. | |||
| To enable memory profiling in addition to tracing, compile with `-DTRACY_MEMORY_USAGE=ON` in addition to `-DTRACY_ENABLE=ON`. | |||
|
No, clang-tidy did not find anything interesting. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #640 +/- ##
==========================================
- Coverage 91.62% 91.43% -0.20%
==========================================
Files 36 36
Lines 4682 4656 -26
==========================================
- Hits 4290 4257 -33
- Misses 392 399 +7 ☔ View full report in Codecov by Sentry. |
* update tracy * fix warnings * remove dead code and warnings * add comment
