Added morph animation to ManifoldCAD.org #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #637 +/- ##
=======================================
Coverage 91.62% 91.62%
=======================================
Files 36 36
Lines 4682 4682
=======================================
Hits 4290 4290
Misses 392 392 ☔ View full report in Codecov by Sentry. |
|
Interesting, do you have an animated GIF for that? |
Screen.Recording.2023-12-06.at.10.38.40.PM.mov |
Merged
cartesian-theatrics
pushed a commit
to SovereignShop/manifold
that referenced
this pull request
Mar 11, 2024
* added morph animation * update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I already added rigid animations, I figured it wouldn't take too much more to handle morph target glTF animations as well. This is a nice way to visually demonstrate what a
Warpfunction is doing. Took me a bit to figure out an API that would actually work in general, so I've finally settled onsetMorphStartandsetMorphEnd. Of course glTF morph targets can do much more than this, but I think a simple 2-shape interpolation is good for simplicity.