EXT_manifold -> EXT_mesh_manifold #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #630 +/- ##
=======================================
Coverage 91.40% 91.40%
=======================================
Files 35 35
Lines 4512 4512
=======================================
Hits 4124 4124
Misses 388 388 ☔ View full report in Codecov by Sentry. |
Merged
cartesian-theatrics
pushed a commit
to SovereignShop/manifold
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing feedback from KhronosGroup/glTF#2286 (comment) regarding glTF extension naming conventions. Since I'm pretty sure we're the only ones producing or consuming this extension so far, this feels like a good time to switch. I checked make-manifold and it can successfully read the old
EXT_manifoldfiles (it ignores the unknown extension, but then merges them to make a manifold and re-exports withEXT_mesh_manifold) so this feels pretty minimally invasive.