Fix NaN halfedgeTangents #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #588 +/- ##
=======================================
Coverage 91.41% 91.41%
=======================================
Files 35 35
Lines 4494 4496 +2
=======================================
+ Hits 4108 4110 +2
Misses 386 386
☔ View full report in Codecov by Sentry. |
elalish
commented
Nov 2, 2023
| Manifold smoothed = Manifold::Smooth(surface).Refine(2); | ||
|
|
||
| EXPECT_EQ(smoothed.Status(), Manifold::Error::NoError); | ||
| EXPECT_EQ(smoothed.Genus(), -2); |
There was a problem hiding this comment.
@pca006132 I'm a little surprised this is -2 maybe some small disconnected object somewhere, or tiny hole? The model looks like it ought to be 0. I'm not too worried about it for now, but might be worth looking into at some point.
Merged
cartesian-theatrics
pushed a commit
to SovereignShop/manifold
that referenced
this pull request
Mar 11, 2024
fixed CreateTangents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #584