Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix operations with different numbers of properties #480

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Conversation

elalish
Copy link
Owner

@elalish elalish commented Jul 6, 2023

Fixes #479

There were two related bugs here: one in the Boolean and one in Compose. Compose was not handling properties at all (oops!), while the Boolean was assuming both inputs had the same number of properties. I added several tests inspired by the linked issue, but made them quite a bit more comprehensive.

@elalish elalish self-assigned this Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 93.61% and project coverage change: +0.32 🎉

Comparison is base (dd3445d) 89.94% compared to head (0198042) 90.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
+ Coverage   89.94%   90.27%   +0.32%     
==========================================
  Files          35       35              
  Lines        4286     4318      +32     
==========================================
+ Hits         3855     3898      +43     
+ Misses        431      420      -11     
Impacted Files Coverage Δ
src/manifold/src/csg_tree.cpp 91.40% <89.28%> (-0.42%) ⬇️
src/manifold/src/boolean_result.cpp 97.46% <100.00%> (+0.04%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@elalish elalish merged commit 4b65ff3 into master Jul 6, 2023
@elalish elalish deleted the propBug branch July 6, 2023 20:12
@stephomi
Copy link
Contributor

stephomi commented Jul 6, 2023

Thanks!

@elalish elalish mentioned this pull request Nov 3, 2023
cartesian-theatrics pushed a commit to SovereignShop/manifold that referenced this pull request Mar 11, 2024
* added tests and fixed a bug

* more testing, fixed compose
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when merging 3 objects with UV (NumProp=5)
2 participants