Change curvature API #448
Merged
Change curvature API #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #448 +/- ##
==========================================
+ Coverage 89.66% 89.77% +0.10%
==========================================
Files 35 35
Lines 4249 4274 +25
==========================================
+ Hits 3810 3837 +27
+ Misses 439 437 -2
☔ View full report in Codecov by Sentry. |
elalish
commented
Jun 9, 2023
| @@ -229,7 +229,7 @@ Module.setup = function() { | |||
| }; | |||
|
|
|||
| Module.Manifold.prototype.setProperties = function(numProp, func) { | |||
| const oldNumProp = this.numProp; | |||
| const oldNumProp = this.numProp(); | |||
There was a problem hiding this comment.
This was a bug - reading existing properties didn't work before.
|
Sounds goos, I'll plan to add the new bindings after these changes are in. |
Merged
cartesian-theatrics
pushed a commit
to SovereignShop/manifold
that referenced
this pull request
Mar 11, 2024
* new curvature API compiles * tests pass * update JS example and fix bindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to update the curvature API, since I never much liked returning a list that one can only hope stays correlated to output vertices. Now that we have a properties API, I've updated this to simply fill that in as desired. I plan to follow this pattern to add a
CalculateNormalsAPI, which I swear I discussed with someone here, but I can't find the thread now. This is a breaking change, but I don't think we have many users of curvature yet.@geoffder I removed the c bindings related to the old API - the new one should be a lot simpler. I figure you can add it in when you have a chance?