Remove GetProperties() #1022
Merged
Remove GetProperties() #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I remembered just in time another breaking change I've been wanting to make -
GetPropertiessounds like it should be related toSetProperties, but it's not at all. I decided to simply remove it in favor of separateVolume()andSurfaceArea()calls, more in line withCrossSection.Area().I also did a bunch of header reorganization to help Doxygen generate cleaner docs. Much of this is to work around the fact that any member group that includes only static methods will always get sorted after the other groups, which is pretty annoying. So I found ways to group things so they have a combination of static and non-static members so I can decide the order of presentation.