fix data races #1019
Merged
fix data races #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1019 +/- ##
==========================================
- Coverage 91.84% 85.20% -6.65%
==========================================
Files 37 62 +25
Lines 4976 9791 +4815
Branches 0 1052 +1052
==========================================
+ Hits 4570 8342 +3772
- Misses 406 1449 +1043 ☔ View full report in Codecov by Sentry. |
elalish
approved these changes
Nov 2, 2024
| // thread sanitizer doesn't really know how to check when there are too many | ||
| // mutex | ||
| #if defined(__has_feature) | ||
| #if __has_feature(thread_sanitizer) |
There was a problem hiding this comment.
Can we use && instead of two #ifs?
There was a problem hiding this comment.
Probably, I just copied this from clang user manual.
There was a problem hiding this comment.
ok apparently this wouldn't work.
| @@ -109,6 +109,10 @@ struct UpdateProperties { | |||
| } | |||
| const int propVert = triProp[tri][i]; | |||
|
|
|||
| auto old = std::atomic_exchange( | |||
| reinterpret_cast<std::atomic<uint8_t>*>(&counters[propVert]), 1); | |||
| if (old == 1) return; | |||
There was a problem hiding this comment.
Make sure we only write the thing once.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some known data races in our code. The issue with data race is that it is undefined behavior. Also, data race can introduce non-determinism into our code, although that is not yet addressed now.
I think thread sanitizer is happy with our code now, for some reason it reports the custom radix sort as racy, but I have no idea why it is racy (I think I followed the tbb API), so it is exempted for now. For
AddNewEdgeVerts, we are probably using many mutexes, which thread sanitizer is not too happy about, so I exempted it for now either.