Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support googletest with the CMake package name GTest #1002

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

cjmayo
Copy link
Contributor

@cjmayo cjmayo commented Oct 19, 2024

This check fails for me, (and I guess for the alternative Ubuntu libgtest-dev package:
https://packages.ubuntu.com/noble/amd64/libgtest-dev/filelist
)

According to the CMake docs the lower-case name will get checked too. Let's see...

@cjmayo
Copy link
Contributor Author

cjmayo commented Oct 19, 2024

Looks good in https://github.com/elalish/manifold/actions/runs/11419156593/job/31773433403?pr=1002
the only ones downloading from source are still clipper2 and nanobind.

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.81%. Comparing base (d437097) to head (05f57d5).
Report is 127 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1002      +/-   ##
==========================================
- Coverage   91.84%   85.81%   -6.03%     
==========================================
  Files          37       62      +25     
  Lines        4976     9616    +4640     
  Branches        0     1049    +1049     
==========================================
+ Hits         4570     8252    +3682     
- Misses        406     1364     +958     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elalish elalish merged commit e45df5d into elalish:master Oct 19, 2024
21 checks passed
@elalish elalish mentioned this pull request Nov 5, 2024
@cjmayo cjmayo deleted the GTest branch November 8, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants