Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

header file naming/directory structure #701

Closed
pca006132 opened this issue Jan 14, 2024 · 2 comments · Fixed by #918
Closed

header file naming/directory structure #701

pca006132 opened this issue Jan 14, 2024 · 2 comments · Fixed by #918
Labels
breaking change API changes for major versions
Milestone
v3.0

Comments

@pca006132
Copy link
Collaborator

We want to avoid conflicting with header files from other packages.
@pca006132 pca006132 added this to the v3.0 milestone Jan 14, 2024
@cjmayo cjmayo mentioned this issue Jan 31, 2024
Merged
@pca006132
Copy link
Collaborator Author

pca006132 commented Sep 7, 2024 •
edited
Loading

#901 (comment)

@hzeller what do you think if we put all headers inside the manifold subdirectory, and access them as #include "manifold/xxx.h"? We will fix it in the directory structure, not just during CMake install.

@pca006132 pca006132 added the breaking change API changes for major versions label Sep 7, 2024
@hzeller
Copy link
Contributor

hzeller commented Sep 7, 2024

yes, I think that would be good. That way, it is easy to immediately see where headers are coming from and there are no conflicts.

hzeller added a commit to hzeller/openscad that referenced this issue Sep 7, 2024
@hzeller
Use manifold headers relative to path manifold/...
09952c1 
That way, it is easier to see where the header is coming from (in
particular it helps to disambiguate from the svg polygon header).

Also getting ready for whatever elalish/manifold#701
will bring.
@hzeller hzeller mentioned this issue Sep 7, 2024
Closed
@pca006132 pca006132 mentioned this issue Sep 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change API changes for major versions
Projects
None yet
Milestone
v3.0
Development

Successfully merging a pull request may close this issue.

change directory structure pca006132/manifold
2 participants
@hzeller @pca006132