Add alignment and remove static #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the `__attribute__((aligned))` attribute to the `NVCodec` type so that it has "the maximum alignment for the target". This is needed because these structs are placed into a section of the executable and the linker will align the objects to e.g. 16-byte boundaries on x86-64 regardless of the actual size of the object. Currently, the size of this struct is just right, so this is technically not needed, but should it be extended in the future, this will prevent surprises.
It is probably confusing that these objects are marked `static` because they are very much different from usual `static` objects. They are placed in a separate section of the executable and iterated over when looking up codecs. So remove the `static` specifier to prevent any potential confusion.
|
Ah, that would explain why it crashed when I changed the size of NVCodec a while ago. Anyway, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #19 I forgot to add
__attribute__((aligned))toNVCodec, and for some reason I marked the codec objects static, which looking back, I find a confusing choice.