pre-Generate EC2 instance type details out of band #8206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
reviewed
Feb 10, 2025
bryantbiggs
reviewed
Feb 10, 2025
dims
force-pushed
the
pre-generate-ec2-instance-type-details-out-of-band
branch
from
2658cdb to
b776875
Compare
bryantbiggs
added
kind/improvement
area/tech-debt
dims
force-pushed
the
pre-generate-ec2-instance-type-details-out-of-band
branch
3 times, most recently
from
d07c28b to
ecbc650
Compare
Signed-off-by: Davanum Srinivas <[email protected]>
dims
force-pushed
the
pre-generate-ec2-instance-type-details-out-of-band
branch
from
ecbc650 to
23533b2
Compare
bryantbiggs
approved these changes
Feb 10, 2025
cheeseandcereal
removed
the
area/tech-debt
|
xref: #8000 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
DescribeInstanceTypesAPI from a helperec2geninfocommand to pre-generate information we need instead of hardcoding similar to VPC CNI or Karpenter. This avoid making expensive calls at runtime to get the information needed.There's also prior art here as well:
Once we land this, the follow up would be to write a GH action that runs
ec2geninfoand files a PR automatically when there are changes. This takes toil way from maintainers.