Disable metrics-server default addon creation for unsupported regions #8146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-hilaly
reviewed
Jan 16, 2025
| @@ -18,15 +18,15 @@ import ( | |||
| "github.com/weaveworks/eksctl/pkg/utils/tasks" | |||
| ) | |||
|
|
|||
| func CreateAddonTasks(ctx context.Context, cfg *api.ClusterConfig, clusterProvider *eks.ClusterProvider, iamRoleCreator IAMRoleCreator, forceAll bool, timeout time.Duration) (*tasks.TaskTree, *tasks.TaskTree, *tasks.GenericTask, []string) { | |||
| func CreateAddonTasks(ctx context.Context, cfg *api.ClusterConfig, clusterProvider *eks.ClusterProvider, iamRoleCreator IAMRoleCreator, forceAll bool, timeout time.Duration, region string) (*tasks.TaskTree, *tasks.TaskTree, *tasks.GenericTask, []string) { | |||
There was a problem hiding this comment.
nit: region already exists in cfg.ClusterConfig.Metadata.Region
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change addresses bug found in #8145 .
Metrics server addon was recently enabled for default addon creation in cluster create workflow. Cluster creation default workflow began failing in regions that do not currently support metrics-server addon
Until metrics-server is supported in all regions, we must disable default addon creation in the regions listed above.
Testing
us-west-2regioneksclt create cluster. Cluster is created with default addons vpc-cni, coredsn, kube-proxy, and metrics-server installed correctlycn-northwest-1region./eksctl create cluster --region cn-northwest-1. Cluster is created with default addons vpc-cni, coredns, and kube-proxy installed correctly. Metrics server is skipped.Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯