Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_point to three_cushion ruleset #172

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Add is_point to three_cushion ruleset #172

merged 1 commit into from
Jan 3, 2025

Conversation

ekiefl
Copy link
Owner

@ekiefl ekiefl commented Jan 3, 2025

No description provided.

@ekiefl
Copy link
Owner Author

ekiefl commented Jan 3, 2025

@erdo100 this fn should help you :)

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 44.22%. Comparing base (ab2668f) to head (0e89b7f).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pooltool/ruleset/three_cushion.py 16.66% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
- Coverage   44.22%   44.22%   -0.01%     
==========================================
  Files         127      127              
  Lines        8551     8554       +3     
==========================================
+ Hits         3782     3783       +1     
- Misses       4769     4771       +2     
Flag Coverage Δ
service 44.22% <16.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekiefl ekiefl merged commit cfee09e into main Jan 3, 2025
8 of 10 checks passed
@ekiefl ekiefl deleted the ek/3-cush-is-point branch January 3, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant