Don't change the double dash in HTML comments to an en dash #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An extraneous colon made the test never pass.
This uses a regex lookahead to ensure there is no > after the double dash. If it matches either the beginning of the line, or any characters other than <!, then it replaces the double dash with an en dash.
ekalinin
added a commit
that referenced
this pull request
Oct 26, 2015
Don't change the double dash in HTML comments to an en dash
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my solution to #27. The regex is nasty because JavaScript doesn't support negative lookbehinds, but it (seems) to work.
Thanks!