Widont short headlines #18
Conversation
This perhaps isn't as good of a solution as it could be since it doesn't tie into the existing regexp, but it is simple and doesn't trample on any of the other tests. It also allows me to provide awareness of the problem and provide a proposed solution, without investing too much time in trying to modify the regexp.
|
I believe (I didn't verify) this will fail on short text that has one or more inline tags (a, span) with multiple attributes that are space separated. I could definitely see this as being a desirable config item/feature though. |
|
yeah, this will also not do the intended thing on headlines inside of larger texts. I'll take more intentful stab at making the regexp do what I've intended here |
This will also handle strings like "<h1>One Two</h1><p>Three Four Five</p>" or html tags with spaces in them for attributes.
|
OK, I got a solution working with the regexp. Matching group 1 now requires [space][non-space][space][non-space] to trigger, so you'd need four "words" to get the nbsp. Or really three words with a space in front of them. I suppose it'll also match tags with spaces for attributes, (f.e. |
Thus, for "<h1>Foo <a href='#'>bar baz</a></h1>", the h1 tag has for the purposes of the matching regexp three words.
|
Solved the inline tag problem. Let me know what you think. |
I had a problem with a two-word headline overflowing its containing box on a mobile layout, thanks to inadvertent use of widont and the non-breaking space it inserted. Thinking about it, in a case like this, four words is probably the minimum that should have its trailing words non-breaking, but I think there's room for discussion there.
This perhaps isn't the best solution, since I am short-circuiting the regexp, but it was easier to get something that worked and provided a better point for awareness of the problem.