Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't normalize urls #39

Closed
ghost opened this issue Sep 5, 2015 · 3 comments
Closed

Doesn't normalize urls #39

ghost opened this issue Sep 5, 2015 · 3 comments

Comments

@ghost
Copy link

ghost commented Sep 5, 2015

So:

hostname: 'http://website.com' with url: 'page.html' => http://website.compage.html
hostname: 'http://website.com/' with url: '/page.html' => http://website.com//page.html

I'd expect this module to remove and add slashes where necessary.

@ghost
Copy link
Author

ghost commented Sep 5, 2015

If you use a package like https://www.npmjs.com/package/url-join to join the different parts here this problem would be solved.

@ekalinin
Copy link
Owner

ekalinin commented Sep 7, 2015

Hi @ismay

Thanks for report.

ekalinin added a commit that referenced this issue Sep 7, 2015
@ghost
Copy link
Author

ghost commented Sep 7, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant