Fix segfault when running update with --count=1 on a stack with more than one commit #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattskl-openai
added a commit
to mattskl-openai/spr
that referenced
this pull request
Dec 19, 2024
from ejoffe#423 pr:updateC1Segfault
mattskl-openai
added a commit
to mattskl-openai/spr
that referenced
this pull request
Dec 19, 2024
from ejoffe#423 pr:updateC1Segfault --- **Stack**: - #13 - #12 - ➡ #10⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do not merge manually using the UI - doing so may have unexpected results.*
|
Can you try to update your branch on top of origin. There has been a bunch of unit test updates. |
chriscz
force-pushed
the
fix/segfault-on-update
branch
from
36125b9 to
2da13d5
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #420
sortPullRequestsByLocalCommitOrderassumes that all commits in the stack will have a corresponding PR, which is not true.Now I just need to figure out how to add a test for this ;)